DOS ain't dead

KBFR 1.97 "lastest" beta... (Announce)

posted by ecm  , Düsseldorf, Germany, 23.06.2011, 18:15

> This is a very good catch indeed, Christian! I'm impressed at the
> quality of your reviewing. This was the kind of hard to pinpoint bug
> because although not correct in theory the instruction will work... almost
> always!
> It ceased to be correct at some time when the code was shuffled around...
> Might have stayed unfixed w/o your help I dare say.

Well I didn't have time to debug it today anyway as I'm preparing things for a longer leave (will be in England from this Sunday til mid-August) so I omitted that. When I review stuff, I always read through the source code though (if provided publicly).

> The test was omitted as redundant, since we do check for an AT BIOS (using
> only 8086 instructions). A positive result, it is assumed, guarantees at
> least a 286, and also that the BIOS int 9 will call down to int 15/4F.

Ah, yeah. I did glance over that check but didn't think through that. I guess that's sufficient then.

> Thank you! Doesn't look far from a final release, after that.

Certainly.

> And a question to start : should it switch between "." and "," (numeric
> pad) ? What's printed on the key itself, I can't discern on the small
> image I have of a German kb layout if it's a comma or decimal point there...

On the keyboards I have around right now, there's commas there (which makes sense as decimal points are instead decimal commas in German) but I'm no keyboard expert and can't tell you whether all German layouts place the decimal comma on that key and/or what the keyboard driver layout and features should be.

---
l

Complete thread:

• KBFR 1.97 "lastest" beta... - Ninho, 23.06.2011, 11:14 (Announce)
  • KBFR 1.97 "lastest" beta... - ecm, 23.06.2011, 12:51
    • KBFR 1.97 "lastest" beta... - Ninho, 23.06.2011, 15:25
      • KBFR 1.97 "lastest" beta... - ecm, 23.06.2011, 18:15
  • KBFR 1.98 beta, release candidate - Ninho, 26.06.2011, 11:07