DOS ain't dead

save & restore environment (Developers)

posted by boeckmann, Aachen, Germany, 08.03.2026, 22:23

> > > COMMAND.COM is from EDR DOS 20250427
> >
> > This is failing because it is not getting the key, it is getting the
> prefix
> > of the key.
> > ...
> > When it gets the key it doesn't check there's an equals after it, hence
> the
> > key will match any other variable that starts with it.
>
> Thanks!
>
> Maybe that was what the removed s++; line was for:
>
> to include the = (equal sign) in the key.

Yes, get_key does not check for '='. The following seems to fix it (includes the = as part of the key for deletion.


diff --git a/command/comint.c b/command/comint.c
index 5068153..2d785c1 100644
--- a/command/comint.c
+++ b/command/comint.c
@@ -1641,6 +1641,7 @@ GLOBAL VOID CDECL cmd_set( BYTE *s )
        }
 #endif
 
+   s++;                        /* skip over = (include in key name) */
    c = *s;                     /* Save Character               */
    *s = '\0';                  /* terminate keyword            */
    strupr( key );              /* make keyword upper case       */
@@ -1649,7 +1650,7 @@ GLOBAL VOID CDECL cmd_set( BYTE *s )
       crlfflg = YES;
       return;
    }
-   *s++ = c;
+   *s = c;    /* recover first character of value */
 
    if ( *s != 0 ) { /* Add the definition to the end*/
       /* of the environment if the new*/



Complete thread:

• save & restore environment - bencollver, 28.02.2026, 00:52 (Developers)
  • save & restore environment - Rugxulo, 28.02.2026, 03:18
    • save & restore environment - bencollver, 28.02.2026, 04:26
      • save & restore environment - Rugxulo, 01.03.2026, 00:24
  • save & restore environment - boeckmann, 28.02.2026, 10:23
    • save & restore environment - bencollver, 28.02.2026, 15:20
      • save & restore environment - boeckmann, 28.02.2026, 19:26
        • save & restore environment - bencollver, 01.03.2026, 15:12
        • save & restore environment - bencollver, 08.03.2026, 00:45
          • save & restore environment - jadoxa, 08.03.2026, 01:39
            • save & restore environment - bencollver, 08.03.2026, 02:05
              • save & restore environment - boeckmann, 08.03.2026, 22:23
                • save & restore environment - boeckmann, 09.03.2026, 17:15
                  • save & restore environment - bencollver, 09.03.2026, 20:09